Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make building executables optional with CMake. #78

Merged

Conversation

flederwiesel
Copy link
Contributor

@flederwiesel flederwiesel commented Dec 21, 2023

If you don't want to build the executables, set BUILD_SHAPELIB_EXECUTABLES to OFF when configuring with CMake.

@flederwiesel flederwiesel changed the title Make building executables optional. Make building executables optional with CMake. Dec 21, 2023
@rouault
Copy link
Member

rouault commented Dec 21, 2023

In other projects of the ecosystem (namely GDAL and PROJ), we've standardized on "BUILD_APPS" for that option

BUILD_SHAPELIB_CONTRIB default value shoud likely be the same as BUILD_APPS (that is if you disable BUILD_APPS, you want contrib utilities to be disabled by default too)

Set BUILD_SHAPELIB_CONTRIB to ${BUILD_APPS}.
@flederwiesel
Copy link
Contributor Author

Thanks. I did not know about BUILD_APPS, as I am using the shapelib only as dependency of another project (which is not even mine :D).
As with the value of BUILD_APPS being the default for BUILD_SHAPELIB_CONTRIB, I added a comment about changing the value of the former requiring the latter to be changed explicitly, as to some this might not immediately occur, if not familiar with CMake.

@rouault rouault merged commit 911df32 into OSGeo:master Dec 23, 2023
4 checks passed
@flederwiesel flederwiesel deleted the feature/make-building-executables-optional branch December 23, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants