Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large preview dialogs don't work #1

Open
jamsden opened this issue Mar 8, 2018 · 2 comments
Open

Large preview dialogs don't work #1

jamsden opened this issue Mar 8, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@jamsden
Copy link

jamsden commented Mar 8, 2018

Large preview dialogs are either blank or show the same content as the small preview. This is because handling the large preview uses the HTML rendering, and this is currently modified by user code to redirect the user to the Watson IoT platform. The code to render HTML is essentially dead code.

We need updates to the Lyo Designer templates to generate separate REST services for large previews (same as for small preview). This will provide flexibility for implementations.

@jadelkhoury
Copy link

Suggestion is that the generator produces the same initial html for both small & large previews, but for 2 different pages. User can then modify content as desired.
It would be hard otherwise for the generator to guess what fields to produce for the different views.

@jadelkhoury
Copy link

While dealing with this issue, could you maybe clarify how the end-user is meant to choose between small and large?
Is it so that the small preview should have a link that allows user to expand a small to a large?
I thought we can introduce such code as well - if desired.

@berezovskyi berezovskyi added the bug Something isn't working label Nov 10, 2020
jamsden pushed a commit that referenced this issue Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants