Set user-agent when making requests to the OSM API #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-low
approved these changes
Aug 27, 2024
| @@ -375,3 +375,4 @@ | |||
| ) | |||
|
|
|||
| OSMCHA_URL = env('OSMCHA_URL', default='https://osmcha.org') | |||
| OSM_API_USER_AGENT = {"User-Agent": "OSMCha osmcha-django v4"} | |||
There was a problem hiding this comment.
IMO "v4" would ideally get read from __version__.py or similar somewhere in the repository, so we don't forget to update this string when v5 is released. But I grepped and it looks like the current version isn't actually stored anywhere in the codebase (just in the git tags) so I'm fine with hard-coding for now. I'll try to make a mental note that this is something that needs updating next time there's a major version bump. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.