Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pandas<2 pinning [all tests ci] #1080

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Jul 19, 2023

We pinned Pandas to <2 (PR #1027) due to xarray not supporting Pandas 2 at the time. But that xarray limitation was removed in April (see pydata/xarray#7785, pydata/xarray#7650).

@emiliom emiliom added this to the 0.8.0 milestone Jul 19, 2023
@emiliom emiliom requested a review from leewujung July 19, 2023 02:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #1080 (a1586c5) into dev (c5afb65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1080   +/-   ##
=======================================
  Coverage   77.71%   77.71%           
=======================================
  Files          67       67           
  Lines        6254     6254           
=======================================
  Hits         4860     4860           
  Misses       1394     1394           
Flag Coverage Δ
unittests 77.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leewujung
Copy link
Member

Ok, great! Let's get this merged!

@emiliom emiliom merged commit 60916e0 into OSOceanAcoustics:dev Jul 22, 2023
@emiliom emiliom deleted the unpin_pandas2 branch July 22, 2023 02:29
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants