Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normalization to compute echo range scaling #1463

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Feb 18, 2025

Enforces normalization of beam direction z if normalization of the beam direction vector is not already present. If vector is all zeros, return NaN.

@ctuguinay ctuguinay self-assigned this Feb 18, 2025
@ctuguinay ctuguinay added the bug Something isn't working label Feb 18, 2025
@ctuguinay ctuguinay added this to the v0.9.2 milestone Feb 18, 2025
@ctuguinay ctuguinay changed the title Use align vectors instead of from matrix for a channel-wise rotation Use align vectors for channel-wise rotation Feb 18, 2025
@leewujung leewujung modified the milestones: v0.9.2, v0.10.0, v0.10.1 Feb 18, 2025
@ctuguinay ctuguinay changed the title Use align vectors for channel-wise rotation Use normalization to compute echo range scaling Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (9f56124) to head (96c2ea3).
Report is 194 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1463       +/-   ##
===========================================
+ Coverage   83.52%   95.17%   +11.65%     
===========================================
  Files          64        5       -59     
  Lines        5686      311     -5375     
===========================================
- Hits         4749      296     -4453     
+ Misses        937       15      -922     
Flag Coverage Δ
unittests 95.17% <100.00%> (+11.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay
Copy link
Collaborator Author

@leewujung This should be ready for review

@ctuguinay ctuguinay requested a review from leewujung February 25, 2025 01:07
@ctuguinay ctuguinay marked this pull request as ready for review February 25, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants