Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate crypto transactions hash on API #273

Open
huzaifa-99 opened this issue Jan 20, 2023 · 1 comment
Open

Validate crypto transactions hash on API #273

huzaifa-99 opened this issue Jan 20, 2023 · 1 comment
Assignees
Labels
api For any issue that relates to api enhancement New feature or request low priority

Comments

@huzaifa-99
Copy link
Contributor

Currently when we do crypto transaction on frontend, we don't validate their hashes on api to check if the transaction actually took place and it has correct data. What we do is just toggle a boolean/string status to store if the user did the transaction, no actual transaction validation occurs on API. For this reason the system is vulnerable, someone could use the CLI to directly call the api and toggle the status without actually doing a transaction.

To fix this, The idea is that the user will send the transaction hash to the api. The api will then check the transaction on chain, verify metadata and other info and only if correct allow the relevant api call to work.

@huzaifa-99 huzaifa-99 added the api For any issue that relates to api label Jan 20, 2023
@huzaifa-99
Copy link
Contributor Author

At this moment, this is a technical debt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api For any issue that relates to api enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants
@AltiMario @huzaifa-99 and others