Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Litigation Rewire #287

Merged
merged 18 commits into from
Feb 4, 2023
Merged

Litigation Rewire #287

merged 18 commits into from
Feb 4, 2023

Conversation

huzaifa-99
Copy link
Contributor

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for pocre ready!

Name Link
🔨 Latest commit be29bb4
🔍 Latest deploy log https://app.netlify.com/sites/pocre/deploys/63dec19fcbaed80008883c1f
😎 Deploy Preview https://deploy-preview-287--pocre.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@huzaifa-99
Copy link
Contributor Author

Points 1, 2 and 3 from #280 are implemented in API

@huzaifa-99 huzaifa-99 changed the title Litigation Rewire [WIP] Litigation Rewire Jan 26, 2023
@huzaifa-99
Copy link
Contributor Author

Points 4, 5 and 6 from #280 implemented at api level

@huzaifa-99
Copy link
Contributor Author

huzaifa-99 commented Feb 1, 2023

Update Note

All the points from #280 are implemented. In frontend the litigation home page is done, but the details page logic needs to be updated. There is still some work left for the details page and payments for actors needs to be reworked a bit

Since the logic was not straight forward (breaking change), I would like to thoroughly test all workflows before merging.

Test cases

These are the workflows to test

Successful Claim

  1. A user should be able to open a claim for an unclaimed material/creation
  2. Immediately after the claim, the litigation will go in the reconciliation phase (the litigation will be displayed in the 'In Reconciliation' tab in litigation home page)
  3. The assumed author of creation/material should be able to see this litigation (in the 'In Reconciliation' tab in litigation home page)
  4. The litigation should have no jury assigned at this point.

Successful Reconciliation

  1. The assumed author of creation/material in a litigation should be able to see the litigation to reconciliate in the 'In Reconciliation' tab in litigation home page.
  2. If the assumed author responds with "Start litigation", then the litigation should be removed from the 'In Reconciliation' Tab and added to 'In Voting' Tab.
  3. If the assumed author responds with "Withdraw Claim", then the litigation should be removed from the 'In Reconciliation' Tab and added to 'Closed' Tab. The claimer should now have automatically redeemed (made author of) this litigation.

Author not responded, No Jury selected

  1. If the author does not reply in reconciliation window, no jury should be selected and the litigation should be moved from 'In Reconciliation' tab to 'Closed' tab

Author not responded, Claimer Wins

  1. If the author does not reply in reconciliation window, the claimer wins the litigation and the litigation should be moved from 'In Reconciliation' tab to 'Closed' tab.
  2. In the 'Closed' tab, the claimer will be shown a button to 'Claim' the authorship (the user has to click this button and claim, this is a manual step by the user). TO NOTE: the payments are to be reworked (since api need to validate it Validate crypto transactions hash on API #273).

Successful Jury Selection

  1. If the assumed author responds with "Start litigation", then the litigation should be removed from the 'In Reconciliation' Tab and added to 'In Voting' Tab, and the jury should be selected for this litigation

Successful Voting

// THIS ONE DEPENDS ON THE DETAILS PAGE TO BE UPDATED, WILL WRITE TEST CASES WHEN THATS DONE


@AltiMario
Copy link
Collaborator

Amazing description thanks for being so professional

@huzaifa-99
Copy link
Contributor Author

huzaifa-99 commented Feb 3, 2023

The ticket #280 is now implemented. I will be testing this and fixing any potential bugs before merge

@huzaifa-99
Copy link
Contributor Author

huzaifa-99 commented Feb 3, 2023

These test cases have worked for me

  • Successful Claim
  • Successful Reconciliation
  • Successful Jury Selection
  • Author not responded, No Jury selected
  • Author not responded, Claimer Wins and can 'Claim' manually
  • Successful Voting - If claimer wins, they can 'Claim' manually

@huzaifa-99 huzaifa-99 changed the title [WIP] Litigation Rewire Litigation Rewire Feb 3, 2023
@huzaifa-99
Copy link
Contributor Author

Test cases worked for me, there were 2 bugs which are now fixed in 4c51205 and be29bb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants