Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The maintainer assignation doesn't happen if there's no relevant code owner at all #39

Closed
saschanaz opened this issue Jun 20, 2023 · 0 comments · Fixed by #40
Closed

The maintainer assignation doesn't happen if there's no relevant code owner at all #39

saschanaz opened this issue Jun 20, 2023 · 0 comments · Fixed by #40

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Jun 20, 2023 •
edited
Loading

code-owner-self-merge/index.js

Lines 55 to 58 in 7abfe9e

if (!codeowners.users.length) {
console.log("This PR does not have any code-owners")
process.exit(0)
}

But it seems this early return shouldn't happen, it should proceed and assign maintainers, right?

See also microsoft/TypeScript-DOM-lib-generator#1581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not early return when no relevant code owner exists saschanaz/code-owner-self-merge
1 participant
@saschanaz