chromium: Fix ARM build with recent glibc #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in OSSystems#729. Signed-off-by: Max Ihlenfeldt <max@igalia.com>
|
@nrpt-m can you please do a test build on master for qemuarm to make sure I got everything right? |
@MaxIhlenfeldt |
|
Thank you both! |
|
btw. see this madler/zlib#764 you might want to use that one. |
|
Thanks, I've subscribed to that PR too. Too bad that issues and PRs in that repository are not acted upon very actively. In this specific case I think both approaches work since these internal zlib files that do include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #729.