Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Source Uri and other warnings in zram-init and telegraf #90

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

flarno11
Copy link
Contributor

SRC_URI seems to be wrong, nothing gets checked out and the recipe fails with zram-init-git-r0 do_populate_lic: QA Issue: zram-init: LIC_FILES_CHKSUM points to an invalid file.

Changing LICENSE to GPL-2.0-only fixes the WARNING: zram-init-git-r0 do_package_qa: QA Issue: Recipe LICENSE includes obsolete licenses GPLv2 [obsolete-license]

The telegraf recipe requires internet access during compilation.

@arthursdo
Copy link
Contributor

Thank you for your contribution to our project. I've reviewed your recent Pull Request and noticed that the commit messages exceed our 80-column limit. For our project, adhering to this limit is crucial because it ensures optimal readability when viewing logs in the terminal, which is a common practice in our workflow.

Could you please update the commit messages to align with this 80-column standard? This will help maintain consistency and readability across our project logs.

This commit fixes the SRC_URI for the zram-init recipe. It sets the scheme to
git:// to ensure a Git clone is done and uses protocol=https, the current
standard protocol. This change ensures the zram-init recipe can fetch the
source code using the supported HTTPS protocol. The change in the LICENSE field
fixes the obsolete-license warning.

Signed-off-by: Flarno <flarno11@gmail.com>
This commit fixes the SRC_URI for the telegraf recipe. It sets the scheme to
git:// to ensure a Git clone is done and uses protocol=https, the current
standard protocol. This change ensures the telegraf recipe can fetch the source
code using the supported HTTPS protocol and access the internet during the
compilation.

Signed-off-by: Flarno <flarno11@gmail.com>
@flarno11
Copy link
Contributor Author

Sure, I've updated the commit messages.

@arthursdo
Copy link
Contributor

Thanks for your work on the meta-ossystems-base project – it’s much appreciated.

I've had a look at PR #90 and everything seems in good shape. Great job on that! There's just one small thing I'd like to ask for. Could you add a blank line at the second line of each commit? It's a small detail but it helps with the overall readability of the commit history.

Thanks again for your contribution.

@flarno11
Copy link
Contributor Author

I am not sure I understand. There seems to be already a blank line:

% git log
commit 40d2fa6da67515920ff68abe6c373482fd63bdf2 (HEAD -> patch-2, origin/patch-2)
Author: flarno11 <flarno11@gmail.com>
Date:   Tue Nov 21 10:46:02 2023 +0100

    telegraf: Fix Source Uri and allow network access

    This commit fixes the SRC_URI for the telegraf recipe. It sets the scheme to
    git:// to ensure a Git clone is done and uses protocol=https, the current
    standard protocol. This change ensures the telegraf recipe can fetch the source
    code using the supported HTTPS protocol and access the internet during the
    compilation.

    Signed-off-by: Flarno <flarno11@gmail.com>

commit 95c43a3b23b7de3643d3821d33000ebda8ea7156
Author: flarno11 <flarno11@gmail.com>
Date:   Tue Nov 21 10:41:16 2023 +0100

    zram-init: Fix Source Uri and update License

    This commit fixes the SRC_URI for the zram-init recipe. It sets the scheme to
    git:// to ensure a Git clone is done and uses protocol=https, the current
    standard protocol. This change ensures the zram-init recipe can fetch the
    source code using the supported HTTPS protocol. The change in the LICENSE field
    fixes the obsolete-license warning.

    Signed-off-by: Flarno <flarno11@gmail.com>

Copy link

Successfully created backport PR #91 for kirkstone.

Copy link

Successfully created backport PR #92 for mickledore.

@flarno11 flarno11 deleted the patch-2 branch December 3, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants