Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sentinel): enhance RedisSentinel reconciliation logic and update workflow. #1176

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

drivebyer
Copy link
Collaborator

  • Added new reconciler functions for handling finalizers, annotations, replication, and sentinel management in the RedisSentinel controller.
  • Improved error handling and logging for better debugging during reconciliation.
  • Updated GitHub Actions workflow to include new job types: standalone, replication, sentinel, and cluster.

This update enhances the functionality and maintainability of the RedisSentinel operator.

Description

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

- Added new reconciler functions for handling finalizers, annotations, replication, and sentinel management in the RedisSentinel controller.
- Improved error handling and logging for better debugging during reconciliation.
- Updated GitHub Actions workflow to include new job types: standalone, replication, sentinel, and cluster.

This update enhances the functionality and maintainability of the RedisSentinel operator.

Signed-off-by: yangw <wuyangmuc@gmail.com>
@drivebyer drivebyer added the enhancement New feature or request label Dec 19, 2024
@drivebyer drivebyer changed the title feat: enhance RedisSentinel reconciliation logic and update workflow. feat(sentinel): enhance RedisSentinel reconciliation logic and update workflow. Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 41.81818% with 32 lines in your changes missing coverage. Please review.

Project coverage is 30.21%. Comparing base (60ef5a2) to head (7e6b9e4).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...trollers/redissentinel/redissentinel_controller.go 43.39% 20 Missing and 10 partials ⚠️
...ontrollers/rediscluster/rediscluster_controller.go 0.00% 1 Missing ⚠️
...rs/redisreplication/redisreplication_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   30.20%   30.21%   +0.01%     
==========================================
  Files          55       55              
  Lines        6294     6400     +106     
==========================================
+ Hits         1901     1934      +33     
- Misses       4200     4268      +68     
- Partials      193      198       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer enabled auto-merge (squash) December 19, 2024 15:23
@drivebyer drivebyer disabled auto-merge December 19, 2024 15:23
@drivebyer drivebyer merged commit 2c7022a into OT-CONTAINER-KIT:master Dec 19, 2024
19 of 20 checks passed
@drivebyer drivebyer deleted the sentinel branch December 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant