Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label selector mapping on redisreplication pdb #1191

Merged

Conversation

husnialhamdani
Copy link
Contributor

Description
Fixes label selector mapping on redisreplication pdb (that previously added in #1166)

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@husnialhamdani
Copy link
Contributor Author

@drivebyer please double check from your side,
the PDB was successfully created but the target selector is not matched with the labels of RedisReplication's Pod

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@husnialhamdani husnialhamdani force-pushed the fixes-pdb-redisreplication branch from 274c919 to 5062bbb Compare December 26, 2024 17:18
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.27%. Comparing base (60ef5a2) to head (5062bbb).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/poddisruption.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
- Coverage   30.20%   29.27%   -0.93%     
==========================================
  Files          55       56       +1     
  Lines        6294     6483     +189     
==========================================
- Hits         1901     1898       -3     
- Misses       4200     4409     +209     
+ Partials      193      176      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@husnialhamdani husnialhamdani changed the title fixes: label selector mapping on redisreplication pdb fix: label selector mapping on redisreplication pdb Dec 26, 2024
@drivebyer drivebyer enabled auto-merge (squash) December 27, 2024 06:47
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit 5ccd226 into OT-CONTAINER-KIT:master Dec 27, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants