Bugfix get_nameid_unspecified and friends (refs #52) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like these methods are called with extra arguments (e.g. sp_entityid), which are not used in these specific methods. Of course, Python complains if they are passed. By allowing any kwargs, these are silently ignored (as I believe they should, since they are not relevant). I only encountered the problem for get_nameid_unspecified, but I noticed some other methods that might have the same problem so I changed them as well.
mjholtkamp
force-pushed
the
feature/bugfix-get_nameid_unspecified
branch
from
55d461e to
d8df54c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these methods are called with extra
arguments (e.g. sp_entityid), which are not used
in these specific methods.
Of course, Python complains if they are passed.
By allowing any kwargs, these are silently
ignored (as I believe they should, since they
are not relevant).
I only encountered the problem for
get_nameid_unspecified, but I noticed some other
methods that might have the same problem so I
changed them as well.