Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

テキストがセリフごとに分割されない可能性がある問題を修正(なろうについて) #13

Closed
TakenPt opened this issue Mar 6, 2024 · 0 comments · Fixed by #21
Closed

テキストがセリフごとに分割されない可能性がある問題を修正(なろうについて) #13

TakenPt opened this issue Mar 6, 2024 · 0 comments · Fixed by #21
Assignees
@TakenPt

Comments

@TakenPt
Copy link

TakenPt commented Mar 6, 2024 •
edited
Loading

「<ruby></ruby>「」」のように「」の中にルビがある際、テキストがセリフごとに分割されない（SplitBraceに誤ったテキストを渡してしまうために起こる）
@TakenPt TakenPt self-assigned this Mar 6, 2024
TakenPt added a commit that referenced this issue Mar 14, 2024
@TakenPt
Merge branch 'main' into feat/#13
a6d5a5d
aiueo-1234 added a commit that referenced this issue Mar 15, 2024
@aiueo-1234
#13 ScrapingHelperのサービス化
e8d12b9
@TakenPt TakenPt changed the title テキストがセリフごとに分割されない可能性がある問題を修正 テキストがセリフごとに分割されない可能性がある問題を修正(なろうについて) Mar 15, 2024
@aiueo-1234 aiueo-1234 mentioned this issue Mar 15, 2024
Merged
aiueo-1234 added a commit that referenced this issue Mar 15, 2024
@aiueo-1234
#13 名称変更
5c3bcb6
aiueo-1234 added a commit that referenced this issue Mar 16, 2024
@aiueo-1234
#13 DI追加
49f9758
aiueo-1234 added a commit that referenced this issue Mar 16, 2024
@aiueo-1234
#13 DI追加
95d95a2
aiueo-1234 added a commit that referenced this issue Mar 16, 2024
@aiueo-1234
#13 DI追加
4254afa
@miyaji255 miyaji255 linked a pull request Mar 16, 2024 that will close this issue
splitBraceに渡すテキストが不適切に分割される問題の修正 #21
Merged
aiueo-1234 added a commit that referenced this issue Mar 16, 2024
@aiueo-1234
Merge branch 'main' into feat/#13
40b64a0
TakenPt added a commit that referenced this issue Mar 18, 2024
@TakenPt
#13 IEnumerable<string> SplitBrace(IEnumerable<string> texts);
b3f662c 
を削除
TakenPt added a commit that referenced this issue Mar 22, 2024
@TakenPt
#13 StringStoreがIEnumerable<string>を受け付けるよう変更
a5b3aef
TakenPt added a commit that referenced this issue Mar 22, 2024
@TakenPt
#13 StringStorerからStringStoreBuilderに名前を変更
bfdbd86
TakenPt added a commit that referenced this issue Mar 22, 2024
@TakenPt
#13 不要なusingの削除、名前空間の変更
d1cd9d7
miyaji255 added a commit that referenced this issue Mar 30, 2024
@miyaji255
#13 テストの追加と名前の修正
3c68caa
miyaji255 added a commit that referenced this issue Mar 30, 2024
@miyaji255
#13 for文の単純化
4b85a1c
miyaji255 added a commit that referenced this issue Mar 30, 2024
@miyaji255
#13 削除忘れを削除
c5ed389
miyaji255 added a commit that referenced this issue Mar 30, 2024
@miyaji255
Merge pull request #21 from OUCC/feat/#13
ec1e0a7 
splitBraceに渡すテキストが不適切に分割される問題の修正
miyaji255 added a commit that referenced this issue Mar 31, 2024
@miyaji255
#13 リファクタリング
6dce10c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TakenPt TakenPt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

splitBraceに渡すテキストが不適切に分割される問題の修正 OUCC/KoeBook
1 participant
@TakenPt