Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trustee names back to Windows fileeffectiverights_item, regkeyeffectiverights_item, fileauditedpermissions_item, regkeyauditedpermissions_item #156

Closed
vanderpol opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State Microsoft Issue related to the Microsoft schema.
Milestone

Comments

@vanderpol
Copy link
Member

vanderpol commented Sep 23, 2024

Abstract
Several Windows tests had their trustee name removed from the items, because trustee names are not always unique, and the SID should be used for accuracy. However the trustee name and group name should still be included to make the results readable/understandable by human end users. Providing SIDS is accurate, but generally meaningless.

These changes should not impact any existing content, just provide more meaningful results.

Tests:
fileeffectiverights_item: Un-deprecate trustee_name
fileauditedpermissions_item Un-deprecate trustee_name
regkeyeffectiverights_item: Un-deprecate trustee_name
regkeyauditedpermissions_item: Un-deprecate trustee_name
user_sid_item add 'user' and 'group' (from user_item, which this test replaced)
group_sid_item add 'group', 'user' and 'subgroup' (from group_item), which this test replaced).

Link to Proposal
Once a proposal has been put into pull request form, add a link to the PR here. If and as alternate proposals or objections are added they should be linked here as well.

Additional context
Add any other context or screenshots about the enhancement.

@vanderpol vanderpol added the Microsoft Issue related to the Microsoft schema. label Sep 23, 2024
@vanderpol vanderpol added this to the 5.12 milestone Sep 23, 2024
@vanderpol vanderpol self-assigned this Sep 23, 2024
@vanderpol vanderpol changed the title Add trustee name and/or group name back to several Windows tests Add trustee name (username and/or group name) back to several Windows tests Sep 26, 2024
@vanderpol vanderpol changed the title Add trustee name (username and/or group name) back to several Windows tests Add trustee names back to Windows fileeffectiverights_item, user_sid_item and group_sid_item Oct 3, 2024
@vanderpol vanderpol changed the title Add trustee names back to Windows fileeffectiverights_item, user_sid_item and group_sid_item Add trustee names back to Windows fileeffectiverights_item, regkeyeffectiverights_item, user_sid_item and group_sid_item Oct 3, 2024
@vanderpol vanderpol changed the title Add trustee names back to Windows fileeffectiverights_item, regkeyeffectiverights_item, user_sid_item and group_sid_item Add trustee names back to Windows fileeffectiverights_item, regkeyeffectiverights_item, fileauditedpermissions_item, regkeyauditedpermissions_item Oct 4, 2024
@vanderpol
Copy link
Member Author

Merged in PR, closing issue

@vanderpol vanderpol added the Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State Microsoft Issue related to the Microsoft schema.
Projects
None yet
Development

No branches or pull requests

1 participant