-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move logic to action file #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see some kind of automated tests
@JisanAR03 can you use this project as the test project? So it is self contained? |
|
@JisanAR03 you mentioned having a test project so can you use this repository to have the test project? Ideally we can have a github action in this repository that can test creating an issue adding "/ assign" to it and see if it gets assigned to the user? or if there was a way to make the code more modular and test individual functions that might work too. My main concern is that we have some automated test to make sure it always works. |
@DonnieBLT sir, then I think I should update this PR with the workflow file. and then you can check here. Is it ok, sir? |
@DonnieBLT , actually, sir I only added few lines of code but for the "if (issue && proceedWithIssueProcessing) {" line, github shows I edited all of the code 🙂 I just added the below code :
|
ok let's go with it, thanks. hopefully everything continues to work. Can you please test after it's merged? |
@DonnieBLT , thank you so much sir ☺ |
yeah sir sure .. I will test this after merge the "BLT" pr |
awesome, nice work, thanks! |
Can you please also update the readme |
yeah sir sure , I will make one more PR after update the Readme |
work : before run the assign function, we just check the comment body and behalf of this, run the assign function , so it's fixed issue #10 and #11
Note: To apply these changes in BLT, we have to update the workflow file in BLT, and for this, please approve PR: OWASP-BLT/BLT#1753