Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Check for duplicate #206

Merged
merged 11 commits into from
Mar 5, 2023
Merged

[New Feature] Check for duplicate #206

merged 11 commits into from
Mar 5, 2023

Conversation

letsintegreat
Copy link
Contributor

Fixes #186

Using the newly created API endpoint, implemented "check for duplicate" feature. Find the demonstration below -

Emulator.-.Flutter.2023-03-04.18-14-50.mp4

Copy link
Collaborator

@justary27 justary27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@letsintegreat Add the issue number also in the check if duplicate dialog

@letsintegreat
Copy link
Contributor Author

@letsintegreat Add the issue number also in the check if duplicate dialog

Hey, I fail to understand what additional information does a user get by the issue number. As I understand issue number is only relevant for identifying an issue uniquely, and has no meaning at the user level. Adding irrelevant information would just add up to the noise. What do you think?

@justary27
Copy link
Collaborator

@letsintegreat Add the issue number also in the check if duplicate dialog

Hey, I fail to understand what additional information does a user get by the issue number. As I understand issue number is only relevant for identifying an issue uniquely, and has no meaning at the user level. Adding irrelevant information would just add up to the noise. What do you think?

Just giving the issue description doesn't give proper context to where the issue had been put earlier hence an issue number which will be more convincing to the user.

@letsintegreat
Copy link
Contributor Author

Just giving the issue description doesn't give proper context to where the issue had been put earlier hence an issue number which will be more convincing to the user.

Yes, you are right that the description is not enough, but I think you missed the clickable link. If the user isn't sure whether they are submitting a duplicate just by looking at the description, they can click on that link to quickly get additional information. I think a link serves the purpose better than the issue number. Please correct me if I am wrong.

@justary27
Copy link
Collaborator

I think a user would like some meta information regarding the link they're going to open first. Giving that will provide some incentive to do so.

@letsintegreat
Copy link
Contributor Author

I think a user would like some meta information regarding the link they're going to open first. Giving that will provide some incentive to do so.

Agreed, user would want to see where they are being headed before clicking the link. So like I should change

Ensure you are not submitting a duplicate bug by clicking here

to

Ensure you are not submitting a duplicate bug by clicking here: https://www.bugheist.com/issue/2069/

@justary27
Copy link
Collaborator

@letsintegreat Can you share the changed UI screen now?

@letsintegreat
Copy link
Contributor Author

@letsintegreat Can you share the changed UI screen now?

Yep, sure. Here -

image

@justary27
Copy link
Collaborator

@letsintegreat Please change the link color

@letsintegreat
Copy link
Contributor Author

@just-ary27

image

@justary27
Copy link
Collaborator

Thanks

@justary27 justary27 enabled auto-merge March 5, 2023 18:36
@justary27 justary27 added this pull request to the merge queue Mar 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2023
@fredfalcon fredfalcon merged commit 88268c5 into OWASP-BLT:main Mar 5, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants