Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min-height to pages with less content #1012

Merged
merged 7 commits into from
Jan 3, 2023

Conversation

ManishBisht777
Copy link
Contributor

Added min-height to the pages with less content

changes

Added min-height to :

  1. signup.html
  2. search.html
  3. leaderboard.html

I am using prettier to I ended up formatting the code as well :)

Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just change the min height part and not the other code?

@ManishBisht777
Copy link
Contributor Author

actually, I am using a formatter so I did end up formatting the files. i will make the changes

@ManishBisht777
Copy link
Contributor Author

@fredfalcon hope it is good now :)

@fredfalcon
Copy link
Contributor

Thank you!

@fredfalcon fredfalcon enabled auto-merge (squash) January 3, 2023 16:38
@fredfalcon fredfalcon merged commit 3c3995b into OWASP-BLT:main Jan 3, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
* Min-height to pages with less content

* Undo prettier format Signup.html

* undo prettier format search.html

* undo perttier for leaderboard_specific_month

* undo eachmoth.html

* undo global leaderboard

Co-authored-by: manish bisht <manishbisth9711@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants