Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing translations #828 #1437

Merged
merged 15 commits into from
Oct 9, 2023
Merged

Conversation

JisanAR03
Copy link
Contributor

@JisanAR03 JisanAR03 commented Sep 25, 2023

fix - #828
i make this PR again after target the correct file ,i'm very sry for my previous mistake

BLT use for translate language : i18n, i just make some changes on template i mean just rewrite some text with "{% trans '' %}" and also i did some changes on locale folder because i had translate some text manually because they are translate automatically .

Note : i run a command at bash is : apt-get install gettext (for install gettext pakage)

I attach some image of before and after :
before:

image

after :

image

i fix all page like this for each language.

@AtmegaBuzz
Copy link
Collaborator

LGTM @DonnieBLT

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of tweaks

website/templates/hunt.html Outdated Show resolved Hide resolved
website/templates/index.html Outdated Show resolved Hide resolved
website/templates/mobile_about.html Outdated Show resolved Hide resolved
@JisanAR03
Copy link
Contributor Author

@DonnieBLT I will make PR again after update the code,, thanks for the review sir

website/templates/hunt.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can translate the "Ant plan" etc

@DonnieBLT DonnieBLT changed the title Issue #828 Adding missing translations Oct 6, 2023
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good just a few places where the project name is mentioned please make sure it's a variable and that it's not in a translation file

locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
website/templates/index.html Outdated Show resolved Hide resolved
website/templates/index.html Outdated Show resolved Hide resolved
@JisanAR03
Copy link
Contributor Author

JisanAR03 commented Oct 9, 2023

It's looking good just a few places where the project name is mentioned please make sure it's a variable and that it's not in a translation file

after solve those i made one more commit please check it out sir ---maybe there is env file is missing---

@JisanAR03
Copy link
Contributor Author

@DonnieBLT I'm sorry sir ,, i should notice that one,, should i commit one more commit sir?

@DonnieBLT
Copy link
Collaborator

I think {% load custom_tags %} has to be added to two of the templates

@JisanAR03
Copy link
Contributor Author

{% load custom_tags %}

"{% load custom_tags %}" is already exist sir on those two file
ScreesShot:
image
image

@DonnieBLT
Copy link
Collaborator

yeah not sure why it's not passing - I think it may have something to do with it being in the accounts folder

@JisanAR03
Copy link
Contributor Author

JisanAR03 commented Oct 9, 2023

yeah not sure why it's not passing - I think it may have something to do with it being in the accounts folder

sir i check this one again and it's work fine for signup and login page sir ..can you please check this out for one more time

@JisanAR03
Copy link
Contributor Author

yeah not sure why it's not passing - I think it may have something to do with it being in the accounts folder

@DonnieBLT yes sir that was my mistake i didn't add "{% load custom_tags %}" now i wish everything works fine ..sorry for not understand the issue on first try .

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for this useful contribution.

@DonnieBLT DonnieBLT merged commit bee5bba into OWASP-BLT:main Oct 9, 2023
3 checks passed
@JisanAR03
Copy link
Contributor Author

@DonnieBLT Thank you so much for you time sir

@JisanAR03 JisanAR03 deleted the issue-#828 branch October 9, 2023 14:29
@JisanAR03 JisanAR03 changed the title Adding missing translations Adding missing translations #828 Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants