-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing translations #828 #1437
Conversation
LGTM @DonnieBLT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of tweaks
@DonnieBLT I will make PR again after update the code,, thanks for the review sir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can translate the "Ant plan" etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good just a few places where the project name is mentioned please make sure it's a variable and that it's not in a translation file
after solve those i made one more commit please check it out sir ---maybe there is env file is missing--- |
@DonnieBLT I'm sorry sir ,, i should notice that one,, should i commit one more commit sir? |
I think {% load custom_tags %} has to be added to two of the templates |
yeah not sure why it's not passing - I think it may have something to do with it being in the accounts folder |
sir i check this one again and it's work fine for signup and login page sir ..can you please check this out for one more time |
@DonnieBLT yes sir that was my mistake i didn't add "{% load custom_tags %}" now i wish everything works fine ..sorry for not understand the issue on first try . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for this useful contribution.
@DonnieBLT Thank you so much for you time sir |
fix - #828
i make this PR again after target the correct file ,i'm very sry for my previous mistake
BLT use for translate language : i18n, i just make some changes on template i mean just rewrite some text with "{% trans '' %}" and also i did some changes on locale folder because i had translate some text manually because they are translate automatically .
Note : i run a command at bash is : apt-get install gettext (for install gettext pakage)
I attach some image of before and after :
before:
after :
i fix all page like this for each language.