Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Bug Description Page: Create GitHub issue added #2409

Merged

Conversation

CodeWithBishal
Copy link
Contributor

Part 1

With this commit, The header widget of the issue page is matched with our final UI design
Screenshot 2024-07-07 at 3 33 43 AM

Part 2

If the GitHub issue URL of an Issue is null, the user who created the issue and superuser will get a button to create a GitHub issue.

Upon Clicking on the button the page will hit a request to a BLT API endpoint and create a GitHub issue using GitHub REST API.

The BLT API endpoint I created has several security features,

  • No user can directly open the url - to prevent misuse of the API
  • It will check if GitHub URL for that already exists before creating a new issue
  • It will check if the user is logged in
  • It will check if the same user who raised the issue is trying to create the GitHub issue or if it is a superuser

Part 3

I will continue working on the design aspect of this page to match with our final design layout

@CodeWithBishal CodeWithBishal requested review from DonnieBLT, arkid15r and AtmegaBuzz and removed request for arkid15r July 6, 2024 22:17
initial commit for bug page
With this commit, The header widget of the issue page is matched with our final UI design

Button to create a github issue with an API end point is also added
@CodeWithBishal CodeWithBishal force-pushed the enhancement/bug-description-page branch from 8d02569 to a243a66 Compare July 6, 2024 22:18
@CodeWithBishal CodeWithBishal enabled auto-merge July 6, 2024 22:21
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks

website/views.py Outdated Show resolved Hide resolved
website/templates/includes/_like_dislike_widget.html Outdated Show resolved Hide resolved
website/templates/includes/_like_dislike_widget.html Outdated Show resolved Hide resolved
@CodeWithBishal CodeWithBishal requested a review from DonnieBLT July 7, 2024 07:56
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Django comments from the html. I find them confusing. I don't think html needs comments. If you need comments then please use html comments, but id prefer no comments if you are ok with it.

website/templates/includes/_like_dislike_widget.html Outdated Show resolved Hide resolved
@CodeWithBishal CodeWithBishal merged commit 97b3c2d into OWASP-BLT:main Jul 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants