Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retriever condition improve for better response #2441

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

JisanAR03
Copy link
Contributor

The changes are very small, but we need them. Now our bot will respond more effectively. I was researching the chain and the vector retrieval part for a few hours. For now, they are fine to use.

@DonnieBLT , can you please this PR for merging

Copy link

sentry-io bot commented Jul 12, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/bot.py

Function Unhandled Issue
conversation_chain AttributeError: 'NoneType' object has no attribute 'as_retriever' /api/chat...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

website/bot.py Outdated Show resolved Hide resolved
website/bot.py Outdated Show resolved Hide resolved
@JisanAR03 JisanAR03 requested a review from arkid15r July 12, 2024 19:18
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still hard to tell what's k. Is it a limit for search results number?

LGTM

@JisanAR03
Copy link
Contributor Author

JisanAR03 commented Jul 12, 2024

It's still hard to tell what's k. Is it a limit for search results number?
LGTM

@arkid15r , it's actually the retrieval result amount from vector database based on the user question

@JisanAR03 JisanAR03 requested a review from arkid15r July 12, 2024 19:27
@DonnieBLT DonnieBLT enabled auto-merge (squash) July 15, 2024 21:36
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward so approving

@DonnieBLT DonnieBLT merged commit 11764ae into OWASP-BLT:main Jul 16, 2024
8 checks passed
@JisanAR03 JisanAR03 mentioned this pull request Jul 16, 2024
Copy link

sentry-io bot commented Jul 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'NoneType' object has no attribute 'as_retriever' /api/chatbot/conversation/ View Issue

Did you find this useful? React with a 👍 or 👎

@JisanAR03 JisanAR03 deleted the update_bot_response branch July 24, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants