Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix domain detections in create issue #2535

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

JisanAR03
Copy link
Contributor

Issue:

Previously, the system incorrectly identified URLs with paths as new domains. For example, if "youtube.com" already existed in the database and a user submitted an issue with "youtube.com/home", the system treated "youtube.com/home" as a new domain, creating a duplicate domain object.

Solution:

  • Domain Cleaning: Implemented a function to extract the base domain from URLs, ensuring that "youtube.com" and "youtube.com/home" are recognized as the same domain.
  • Database Check: Updated the domain checking mechanism to prevent the creation of duplicate domain objects for URLs with the same base domain.

Changes Made:

  • Added a clean_domain function to extract the base domain using urlparse.
  • Updated the domain creation logic to check for existing domains using the cleaned domain value.

Example:

  • Before: "youtube.com" and "youtube.com/home" were treated as separate domains.
  • After: Both URLs are recognized as "youtube.com", preventing duplicate entries.

Request for Review:

@DonnieBLT, could you please review these changes for merging?

@DonnieBLT DonnieBLT merged commit 4cdb6a5 into OWASP-BLT:main Aug 1, 2024
8 checks passed
@JisanAR03 JisanAR03 mentioned this pull request Aug 1, 2024
@JisanAR03 JisanAR03 deleted the fix_domain_matching branch August 1, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants