Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Profile page #2631

Merged
merged 8 commits into from
Aug 12, 2024
Merged

Conversation

CodeWithBishal
Copy link
Contributor

Fix some overflow issues in the design of profile page
added an edit button to edit user's crypto address

Copy link

sentry-io bot commented Aug 12, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views.py

Function Unhandled Issue
get_context_data AttributeError: 'NoneType' object has no attribute 'github' /is...
Event Count: 51

Did you find this useful? React with a 👍 or 👎

Fix some overflow issues in the design of profile page
added an edit button to edit user's crypto address
@DonnieBLT
Copy link
Collaborator

@CodeWithBishal the crypto addresses can be edited in the profile edit page now.

@DonnieBLT
Copy link
Collaborator

can you please confirm it works with the profile edit page and adjust the PR to just fix the layout issues

@CodeWithBishal
Copy link
Contributor Author

@DonnieBLT can we keep both of the options? because this PR also contains design adjustments for the profile page to fix overflow issue

@CodeWithBishal
Copy link
Contributor Author

@DonnieBLT after the merge I just need to make a few changes and "edit profile" should work fine with this PR

@CodeWithBishal
Copy link
Contributor Author

right now, in my PR the update_bch_address is expecting a JSON payload which is not the case in the "edit profile" page, need to adjust this and it should work just fine

@DonnieBLT
Copy link
Collaborator

lets keep it simple and just have the full profile edit page

@CodeWithBishal
Copy link
Contributor Author

ok

@CodeWithBishal
Copy link
Contributor Author

I have made the required changes, please review @DonnieBLT

@CodeWithBishal CodeWithBishal merged commit dc3991a into OWASP-BLT:main Aug 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants