Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List like #552

Merged
merged 2 commits into from
Sep 8, 2017
Merged

List like #552

merged 2 commits into from
Sep 8, 2017

Conversation

mohitanand001
Copy link
Contributor

screenshot from 2017-09-08 01 19 45

@mohitanand001 mohitanand001 self-assigned this Sep 7, 2017
@jajodiaraghav
Copy link
Contributor

Why is the same PR made twice? One exactly similar PR #551 already got merged

@mohitanand001
Copy link
Contributor Author

sorry it was a mistake

@jajodiaraghav
Copy link
Contributor

I cannot find the "Liked by" modal in /issue. Please check

@mohitanand001
Copy link
Contributor Author

mohitanand001 commented Sep 8, 2017

Actually the previous PR was not on the master of OWASP/BLT hence this needs to merged.

@jajodiaraghav jajodiaraghav reopened this Sep 8, 2017
@jajodiaraghav jajodiaraghav self-requested a review September 8, 2017 04:45
@jajodiaraghav jajodiaraghav merged commit 91edbc8 into master Sep 8, 2017
@jajodiaraghav jajodiaraghav deleted the list_like branch September 8, 2017 04:47
@jajodiaraghav
Copy link
Contributor

jajodiaraghav commented Sep 8, 2017

@farziengineer I just saw that you have opened several unnecessary branches in the main BLT repository. This kind of mistakes happen when you do not understand the git workflow. I have closed them. Make sure you do not make new branches before creating pulls

DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants