wrong credentials error message showing #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the message is there we just need to show it. We don’t need another view |
|
ok if thats the case then its not passing it in messages in the request cause we already showing all the messages. ill check |
|
@fredfalcon now error is showing without custom view |
|
@fredfalcon resolved. i am marking issues which are done with solved label. if they are done can you close it or if something is remaining add new comment to the issue regarding what else to be fixed |
fredfalcon
approved these changes
Aug 31, 2022
|
Thank you! |
|
If you link the issue to the pr it will close automatically https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* wrong credentials error message showing * fix login error not showing * large filename error fix (#943) * deps removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Wrong login credentials (Validation Message) not showing. #889
prev it was not showing error message
