Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: remove 13.1.2 as it is duplicate #1028

Closed
elarlang opened this issue Jun 21, 2021 · 9 comments
Closed

proposal: remove 13.1.2 as it is duplicate #1028

elarlang opened this issue Jun 21, 2021 · 9 comments
Assignees
Labels
4) proposal for review Issue contains clear proposal for add/change something

Comments

@elarlang
Copy link
Collaborator

V4.3 Other Access Control Considerations

V4.3.1 Verify administrative interfaces use appropriate multi-factor authentication to prevent unauthorized use.

  • Levels: 1, 2, 3
  • CWE 419 (Unprotected Primary Channel)

V13.1 Generic Web Service Security

V13.1.2 Verify that access to administration and management functions is limited to authorized administrators.

  • Levels: 1, 2, 3
  • CWE 419 (Unprotected Primary Channel)

Proposal: remove 13.1.2 as it is duplicate (and authorization questions should be covered in category V4, and should be not duplicated to other categories, like an API)

@jmanico
Copy link
Member

jmanico commented Jun 23, 2021 via email

@elarlang
Copy link
Collaborator Author

I think 4.3.1 should go away

I'm ok with 13.1.2 going away because of duplication.

There seems to be some conflict.

@jmanico
Copy link
Member

jmanico commented Jun 28, 2021

I think 4.3.1 should be removed because the need for multi-factor is covered elsewhere and making multi-factor necessary for admins is not necessary.

13.1.2 looks fine as is.

@elarlang
Copy link
Collaborator Author

Problem with 13.1.2 - it's authorization requirement in API category, but it's not API specific.

@Sjord
Copy link
Contributor

Sjord commented Jun 29, 2021

I agree that 13.1.2 can be removed. All functionality should only be accessible by authorized users. This is not specific to admins or API's. I think the ASVS needs an explicit requirement that states something like "All functionality should only be accessible by authorized users". But that's a separate issue and shouldn't go in V13, so this can be removed.

I think 4.3.1 should be removed because the need for multi-factor is covered elsewhere and making multi-factor necessary for admins is not necessary.

I think this is a separate issue, and perhaps it's better to create a new GitHub issue for this.

@lfservin
Copy link
Contributor

lfservin commented Jul 7, 2021

Maybe fix the title of the issue? This discussion is about 13.1.2 not 13.2.1 ;)

@elarlang elarlang changed the title proposal: remove 13.2.1 as it is duplicate proposal: remove 13.1.2 as it is duplicate Jul 7, 2021
@elarlang
Copy link
Collaborator Author

@jmanico - can you review original proposal and say, do you agree removing 13.1.2 as duplicate or you have some arguments against this proposal?

@elarlang elarlang added the 4) proposal for review Issue contains clear proposal for add/change something label Jul 18, 2021
@jmanico
Copy link
Member

jmanico commented Jul 30, 2021

definitely a duplicate and the OP looks good to me

@cmlh
Copy link
Contributor

cmlh commented Jul 31, 2021

Can this be reworded to verify the authorization of different roles (or is this a duplicate requirement already specified in ASVS)?

jmanico added a commit that referenced this issue Aug 31, 2021
elarlang pushed a commit to elarlang/ASVS that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4) proposal for review Issue contains clear proposal for add/change something
Projects
None yet
Development

No branches or pull requests

5 participants