Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6.4 grammar police strikes again #1545

Closed
jmanico opened this issue Feb 17, 2023 · 5 comments · Fixed by #1635
Closed

1.6.4 grammar police strikes again #1545

jmanico opened this issue Feb 17, 2023 · 5 comments · Fixed by #1635
Assignees
@jmanico @twright-0x1
Labels
6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@jmanico
Copy link
Member

jmanico commented Feb 17, 2023

1.6.4 is still using bad grammar

1.6.4 [GRAMMAR] Verify that the architecture treats client-side secrets - such as symmetric keys, passwords, or API tokens - as insecure and never uses them to protect or access sensitive data.

possible fix (drop the dashes please):

1.6.4 [GRAMMAR] Verify that the architecture treats client-side secrets such as symmetric keys, passwords, or API tokens as insecure and never uses them to protect or access sensitive data.
@elarlang elarlang added the 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR label Feb 18, 2023
@tghosth
Copy link
Collaborator

tghosth commented Mar 14, 2023

@jmanico what do you think about:

1.6.4 [GRAMMAR] Verify that the architecture treats client-side secrets, (such as symmetric keys, passwords, or API tokens,) as insecure and never uses them to protect or access sensitive data.

@elarlang
Copy link
Collaborator

Can you give an example, where this mistake can happen or how it is important?

@jmanico
Copy link
Member Author

jmanico commented Mar 28, 2023

I am not debating the validity of the requirement, I am concerned that this existing requirement has bad grammar. That's it! If you want to discuss the details I suggest you open a new issue.

@tghosth tghosth linked a pull request May 23, 2023 that will close this issue
Fix grammar of 1.6.4 #1635
Merged
@tghosth tghosth mentioned this issue May 23, 2023
Merged
@tghosth
Copy link
Collaborator

tghosth commented May 23, 2023

Can you give an example, where this mistake can happen or how it is important?

@elarlang see #685 for discussion

@tghosth
Copy link
Collaborator

tghosth commented May 23, 2023

Opened a PR to fix grammar

@tghosth tghosth added 6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0 and removed 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmanico jmanico

@twright-0x1 twright-0x1

Labels
6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix grammar of 1.6.4 OWASP/ASVS
4 participants
@jmanico @tghosth @twright-0x1 @elarlang