Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar of 1.6.4 #1635

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix grammar of 1.6.4 #1635

merged 2 commits into from
May 31, 2023

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented May 23, 2023

Reference #1545

@tghosth tghosth linked an issue May 23, 2023 that may be closed by this pull request
@tghosth tghosth requested review from jmanico and elarlang May 23, 2023 16:26
@tghosth tghosth added 6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0 labels May 23, 2023
Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, (such as symmetric keys, passwords, or API tokens,) - this is really confusing syntax (usage of (),), even if it's grammatically correct

@tghosth
Copy link
Collaborator Author

tghosth commented May 23, 2023

What would you prefer? I am willing to be less correct but clearer :)

@elarlang
Copy link
Collaborator

Verify that the architecture treats client-side secrets (such as symmetric keys, passwords, or API tokens) as insecure and never uses them to protect or access sensitive data.

@tghosth
Copy link
Collaborator Author

tghosth commented May 28, 2023

OK so should be ok now @elarlang

@elarlang
Copy link
Collaborator

@jmanico maybe want to verify that, as he opened the issue

@jmanico jmanico merged commit fc84677 into master May 31, 2023
@tghosth tghosth deleted the 1545-164-grammar-police-strikes-again branch June 8, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6.4 grammar police strikes again
3 participants