Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #1291 by clarifying 12.2.1 #1681

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Resolve #1291 by clarifying 12.2.1 #1681

merged 3 commits into from
Aug 7, 2023

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Jul 10, 2023

This Pull Request relates to issue #1291

@tghosth tghosth linked an issue Jul 10, 2023 that may be closed by this pull request
I think the requirement 12.2.1 should be more explicit #1291
Closed
@tghosth tghosth requested a review from elarlang July 10, 2023 06:13
@tghosth tghosth added 6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0 labels Jul 10, 2023
@tghosth tghosth mentioned this pull request Jul 10, 2023
Closed
@tghosth tghosth assigned jmanico and unassigned elarlang Jul 11, 2023
@tghosth tghosth requested review from jmanico and removed request for elarlang July 11, 2023 05:21
elarlang
elarlang reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it checks that the file extension of the file matches an expected type"

instead of "expected type" maybe we should mention "allowed list of file extensions"? File extension and type is just not intuitive to put together,

@tghosth tghosth marked this pull request as draft July 12, 2023 09:50
@tghosth
Copy link
Collaborator Author

tghosth commented Jul 12, 2023

I commented here #1291 (comment)

@tghosth tghosth marked this pull request as ready for review August 5, 2023 23:44
@elarlang elarlang merged commit 2c9059f into master Aug 7, 2023
2 checks passed
@tghosth tghosth deleted the 1291-i-think-the-requirement-1221-should-be-more-explicit branch September 6, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elarlang elarlang elarlang approved these changes

@jmanico jmanico jmanico approved these changes

Assignees

@jmanico jmanico

Labels
6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I think the requirement 12.2.1 should be more explicit
3 participants
@tghosth @jmanico @elarlang