Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation #1973

Merged
merged 54 commits into from
Sep 16, 2024
Merged

Italian translation #1973

merged 54 commits into from
Sep 16, 2024

Conversation

ricsirigu
Copy link
Contributor

This Pull Request relates to issue #1951

I tried to generate the document files, but the makefile is not working on my M1 Mac. I'm trying to figure out why.

@elarlang
Copy link
Collaborator

Hi @ricsirigu, thank you for this huge job! 👏

Now it's my turn to validate the structure and it may take a bit of time.

If I find some tiny formating issues, I'm going to fix them myself (as it takes less time than communicating them). Validation goes with regex matching line-by-line, so it expects line count, order and content matches for each line.

So, let's validate the syntax first and then it's time to check, is there anything needed extra for generating output formats. Those are generated by us and served as static files.

@elarlang
Copy link
Collaborator

Hi again,

so I did "few" changes :) b4f8e6a

Mostly it's spaces, tabs, line-breaks, dots etc. But there are also few things that requires action from you:

  • 0x12-V3-Session-management.md - I deleted few lines that were in English. For me those seemed translated, but just not deleted. Be sure that it was so.
  • 0x20-V12-Files-Resources.md - here, sections 12.2 and 12.4 were missing from translation. I put them back in English, please translate them

@ricsirigu
Copy link
Contributor Author

Hi @elarlang, great! :)
I confirm that the lines you deleted in 0x12-V3-Session-management.md were translated into Italian.
I have just committed the missing section related to 0x20-V12-Files-Resources.md

@elarlang
Copy link
Collaborator

Nice :)

@ricsirigu - as there were some (mentioned) surprises in the translated document, I think it makes sense to let it be read and reviewed by other Italian speakers. As I don't know any, I kindly ask you to find them :)

Meanwhile, I hope @tghosth finds time to test how it works and look for different output formats.

@tghosth
Copy link
Collaborator

tghosth commented May 30, 2024

Hi @ricsirigu, thanks for your work on this.

If the make mechanism is not working on the Mac, can you try running it in something like Google Cloud Shell:
https://cloud.google.com/shell/docs/launching-cloud-shell?cloudshell=true

https://github.com/OWASP/ASVS/blob/master/COMPILING.md

@tghosth
Copy link
Collaborator

tghosth commented Jun 13, 2024

@ricsirigu were you able to test the make functionality on google cloud shell?

@ricsirigu
Copy link
Contributor Author

Hi @tghosth, I’ve gone through everything, and now it reads much more like a natural Italian text rather than just a translation.

@tghosth
Copy link
Collaborator

tghosth commented Sep 15, 2024

Thanks @ricsirigu.

I have generated the formatted outputs. You can download them here:
https://github.com/OWASP/ASVS/actions/runs/10862919936/artifacts/1934169403

Please can you review the contents of the docs_it folder and make sure it looks ok as the final check?

@ricsirigu
Copy link
Contributor Author

Thanks @ricsirigu.

I have generated the formatted outputs. You can download them here: https://github.com/OWASP/ASVS/actions/runs/10862919936/artifacts/1934169403

Please can you review the contents of the docs_it folder and make sure it looks ok as the final check?

@tghosth I standardized some terms, corrected a few typos, and improved the index.

@tghosth
Copy link
Collaborator

tghosth commented Sep 15, 2024

Nice, so you can see the updated artifacts here @ricsirigu . Can you just give them another check?
https://github.com/OWASP/ASVS/actions/runs/10870299629/artifacts/1934774544

@ricsirigu
Copy link
Contributor Author

Nice, so you can see the updated artifacts here @ricsirigu . Can you just give them another check? https://github.com/OWASP/ASVS/actions/runs/10870299629/artifacts/1934774544

@tghosth Looks fine ☑️

@tghosth
Copy link
Collaborator

tghosth commented Sep 15, 2024

OK, almost there, can you approve this PR please: ricsirigu#1

@tghosth tghosth enabled auto-merge (squash) September 15, 2024 18:43
Add Italian documents and references
auto-merge was automatically disabled September 15, 2024 20:04

Head branch was pushed to by a user without write access

@tghosth tghosth enabled auto-merge (squash) September 16, 2024 06:25
@tghosth tghosth merged commit bc7f850 into OWASP:master Sep 16, 2024
5 checks passed
tghosth pushed a commit to tghosth/ASVS that referenced this pull request Sep 16, 2024
* Starting Italian translation

* 0x10 architecture italian

* Authentication ita

* Session management ita

* Access control ita

* validation and sanitization ita

* cryptography in italian

* error loggin italian

* data protection ita

* communications ita

* malicious ita

* buslogic ita

* files and resources ita

* api italian

* config italian

* glossary

* appendix b

* appendix c italian

* typo

* permission-test

* it translation syntax correction

* v12 files and resources italian missing sections

* -tab

* Apply suggestions from code review

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Create docs folder for italian output

* Add it to output languages

* Update 4.0/it/0x10-V1-Architecture.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x10-V1-Architecture.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* V9 missing references translation

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Review to make it more fluent

* Review using ASVS

* 0x04 review

* 0x10 review

* 0x11 review

* 0x12 review

* 0x12 review

* 0x13 review

* 0x14 review

* 0x15 review

* 0x16 review

* 0x17 review

* 0x18 review

* 0x19 review

* 0x20 review

* 0x21 review

* 0x22 review

* Typos

* Fix typos

* Add Italian documents and references

---------

Co-authored-by: Elar Lang <47597707+elarlang@users.noreply.github.com>
Co-authored-by: Elar Lang <elar@hoh.ee>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Co-authored-by: Josh Grossman <tghosth@users.noreply.github.com>
(cherry picked from commit bc7f850)

# Conflicts:
#	4.0/generate-all.sh
#	CONTRIBUTING.md
#	README.md
@tghosth
Copy link
Collaborator

tghosth commented Sep 16, 2024

💚 All backports created successfully

Status Branch Result
v4.0.3

Questions ?

Please refer to the Backport tool documentation

tghosth pushed a commit that referenced this pull request Sep 16, 2024
* Starting Italian translation

* 0x10 architecture italian

* Authentication ita

* Session management ita

* Access control ita

* validation and sanitization ita

* cryptography in italian

* error loggin italian

* data protection ita

* communications ita

* malicious ita

* buslogic ita

* files and resources ita

* api italian

* config italian

* glossary

* appendix b

* appendix c italian

* typo

* permission-test

* it translation syntax correction

* v12 files and resources italian missing sections

* -tab

* Apply suggestions from code review

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Create docs folder for italian output

* Add it to output languages

* Update 4.0/it/0x10-V1-Architecture.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x10-V1-Architecture.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* V9 missing references translation

* Update 4.0/it/0x11-V2-Authentication.md

Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>

* Review to make it more fluent

* Review using ASVS

* 0x04 review

* 0x10 review

* 0x11 review

* 0x12 review

* 0x12 review

* 0x13 review

* 0x14 review

* 0x15 review

* 0x16 review

* 0x17 review

* 0x18 review

* 0x19 review

* 0x20 review

* 0x21 review

* 0x22 review

* Typos

* Fix typos

* Add Italian documents and references

---------

Co-authored-by: Elar Lang <47597707+elarlang@users.noreply.github.com>
Co-authored-by: Elar Lang <elar@hoh.ee>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Co-authored-by: Josh Grossman <tghosth@users.noreply.github.com>
(cherry picked from commit bc7f850)

# Conflicts:
#	4.0/generate-all.sh
#	CONTRIBUTING.md
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants