Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 Access Control Additions #2064

Closed
wants to merge 8 commits into from
Closed

Conversation

EnigmaRosa
Copy link
Contributor

This Pull Request relates to issues #2058 #2059 #2060 #2061 #2062 #2063

@elarlang
Copy link
Collaborator

elarlang commented Sep 5, 2024

hey, to save you time - it does not make sense to create a PR before there is agreement on the related issue:

  • not every proposal materializes as a requirement
  • agreement for different requirements/issues probably comes with different paces that leave already agreed-on issues still opened and "hidden" somewhere in the PR - causes confusion about what is done and what is not and causes conflicts with parallel developments

My recommendation is to create a PR for related issue when there is agreement in the issue - then we can merge it fast and it is clear for everyone, what is done and what is not.


## V4.2 Operation Level Access Control

| # | Description | L1 | L2 | L3 | CWE |
| :---: | :--- | :---: | :---: | :---: | :---: |
| **4.2.1** | Verify that sensitive data and APIs are protected against Insecure Direct Object Reference (IDOR) attacks targeting creation, reading, updating and deletion of records, such as creating or updating someone else's record, viewing everyone's records, or deleting all records. | ✓ | ✓ | ✓ | 639 |
| **4.2.2** | [MOVED TO 50.3.1] | | | | |
| **4.2.3** | [ADDED] Verify that multi-tenant applications use cross-tenant controls to ensure user operations will never affect tenants with which they do not have permissions to interact. | ✓ | ✓ | ✓ | 284 |
| **4.2.4** | Verify that access to an object is based on the originating sybject's (e.g. user's) permissions, not on the permissions of any intermediary or service acting on their behalf. | | | ✓ | 441 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: "subject"

@EnigmaRosa
Copy link
Contributor Author

Thanks @elarlang - I will close this PR and re-submit individually once we've come to a consensus on each issue.

@EnigmaRosa EnigmaRosa closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants