-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address GitHub Issue #1265 #1266
Conversation
Note that vscode's markdownlinter found a few warnings in other sections, but nothing in the section I revised. I did not address those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit late but I added a few grammar nits.
the secret. By that point, the security breach may have already occurred. | ||
|
||
Depending on your particular circumstances, this can be difficult implement in a | ||
manner that ensures memory security. Since determining whether it is beneficial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Since" is the wrong word here. Is there a word that more clearly connects these two sentences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to me do a new PR for these edits? Sorry if I was going too fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
[Meltdown and Spectre](https://meltdownattack.com/), it is important | ||
to understand that the operating system alone is not sufficient to protect your process | ||
memory from these types of attacks. This becomes especially important when your | ||
application is deployed to the cloud. The only fullproof approach to protecting memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fullproof" should be "foolproof"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szh - SMH. I can't believe I messed that up. I even looked it up because I always get it wrong, and I still got it wrong. Sigh.
memory from these types of attacks. This becomes especially important when your | ||
application is deployed to the cloud. The only fullproof approach to protecting memory | ||
against these and similar attacks to fully physically isolate your process memory from all other | ||
untrusted processes. | ||
|
||
Nevertheless, in highly sensitive environments, protecting secrets in memory can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "Nevertheless" makes sense in this context anymore, given the previous paragraph.
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
[TEXT](URL)
If your PR is related to an issue, please finish your PR text with the following line:
This PR covers issue #.
Thank you again for your contribution 😃