Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Threat_Modeling_Cheat_Sheet.md #1368

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

adamshostack
Copy link
Contributor

Added link to project; aligned language to 4 question frame; re-ordered various sections by importance ; removed link to trike which was last updated nearly 20 years ago.

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

Added link to project; aligned language to 4 question frame; removed trike which is last updated nearly 20 years ago.
Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! Thank you!

@jmanico
Copy link
Member

jmanico commented Apr 2, 2024

This is fantastic work; thank you, Adam. There are a few lint errors. Would you mind addressing them?

  • cheatsheets/Threat_Modeling_Cheat_Sheet.md:5:265 MD034/no-bare-urls Bare URL used [Context: "https://owasp.org/www-project-..."]
  • cheatsheets/Threat_Modeling_Cheat_Sheet.md:93 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
  • cheatsheets/Threat_Modeling_Cheat_Sheet.md:94 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### Methods and Techniques"]
  • cheatsheets/Threat_Modeling_Cheat_Sheet.md:96 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- [LINDDUN](https://linddun.or.../"]
  • cheatsheets/Threat_Modeling_Cheat_Sheet.md:102 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

Didn't go to the extent of installing the linter since I'm trying to do this in the web ui. Hope this hits them all, will watch the auto output
@jmanico
Copy link
Member

jmanico commented Apr 2, 2024

One more Adam!

cheatsheets/Threat_Modeling_Cheat_Sheet.md:93 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### Methods and Techniques"]

thanks! next time I'll get the plugin going to save you the work
@jmanico jmanico merged commit 72be6eb into OWASP:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants