Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bad security question #1462

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Added a bad security question #1462

merged 5 commits into from
Aug 29, 2024

Conversation

joshberk
Copy link
Contributor

@joshberk joshberk commented Aug 7, 2024

You're A Rockstar

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #<REPLACE WITH ISSUE NUMBER>.

Thank you again for your contribution 😃

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, otherwise LGTM

@szh szh added the bug_bash_cincy OWASP Cincinnati 2024 Bug Bash! label Aug 7, 2024
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Minor grammar nit

kwwall
kwwall previously approved these changes Aug 9, 2024
Copy link
Collaborator

@kwwall kwwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the typo that @szh noted, LTGM.

jmanico
jmanico previously approved these changes Aug 9, 2024
@szh
Copy link
Collaborator

szh commented Aug 9, 2024

@joshberk do you want to fix the typos? Otherwise I can take care of it.

@jmanico
Copy link
Member

jmanico commented Aug 13, 2024

There are lint errors and typos...

@joshberk joshberk dismissed stale reviews from jmanico and kwwall via 9e0475d August 15, 2024 13:18
joshberk and others added 3 commits August 15, 2024 09:18
Co-authored-by: Shlomo Zalman Heigh <shlomozalmanheigh@gmail.com>
Co-authored-by: Shlomo Zalman Heigh <shlomozalmanheigh@gmail.com>
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackowski mackowski merged commit 1e242df into OWASP:master Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_bash_cincy OWASP Cincinnati 2024 Bug Bash!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants