Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Threat modeling for builders, Threat Composer #1495

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

miiiak
Copy link
Contributor

@miiiak miiiak commented Sep 19, 2024

You're A Rockstar

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • [N/A ] In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • [N/A] All the markdown files do not raise any validation policy violation, see the policy.
  • [N/A] All the markdown files follow these format rules.
  • [N/A] All your assets are stored in the assets folder.
  • [N/A] All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR fixes issue #1482.

Thank you again for your contribution 😃

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. Just one lint error:

cheatsheets/Threat_Modeling_Cheat_Sheet.md:143:276 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

@szh szh linked an issue Sep 19, 2024 that may be closed by this pull request
@miiiak
Copy link
Contributor Author

miiiak commented Sep 19, 2024

Lint fix is in

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mackowski mackowski merged commit 7a72263 into OWASP:master Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Threat_Modeling_Cheat_Sheet
3 participants