Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech writer enhanced clarity of document. #1496

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

thornshadow99
Copy link
Contributor

You're A Rockstar

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR fixes issue #<REPLACE WITH ISSUE NUMBER>.

Thank you again for your contribution 😃

@szh
Copy link
Collaborator

szh commented Sep 23, 2024

I don't have any Django experience. Anyone else able to review this?
Also the lint step is failing.

Fixed the Markdown lint problems. However, I'm not sure why the document invoked the URL Checker on MASWE-0014 Add Cryptographic Keys Not Properly Protected at Rest. The URL Checker fails when it goes through MASWE-0014 for some resason. Any suggestions would be helpful. :)
@thornshadow99
Copy link
Contributor Author

There is a trailing space in line 103 that needs correcting and for some reason the pull request invoked the URL Checker on a different file. Otherwise it is fine.

mackowski
mackowski previously approved these changes Oct 1, 2024
Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cheatsheets/Django_REST_Framework_Cheat_Sheet.md Outdated Show resolved Hide resolved
@jmanico jmanico merged commit e3cb268 into OWASP:master Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants