Skip to content

Clarify wording of password sending recommendation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

n-l-i
Copy link
Contributor

@n-l-i n-l-i commented Apr 27, 2025

Summary :

This includes a small improvement in wording in 04-design/02-web-app-checklist/06-digital-identity.md

The recommendation for sending passwords can be read two ways, either as "Always send non-temporary passwords encrypted" or as "Don't send temporary passwords encrypted". This commit clarifies that the former interpretation is the intended one.

Description for the changelog :

Clarify wording of password sending recommendation

Declaration:

  • content meets the license for this project
  • AI has not been used, or has been declared, in this pull request

Other info :

Thanks for submitting a pull request!

Please make sure you follow our Code of Conduct
and our contributing guidelines

Automated tests are run to check links, markdown and spelling

The pull request must pass these tests before it can be merged

@jgadsden
Copy link
Contributor

Hello @n-l-i , could you clarify why this change in wording is better?

@n-l-i
Copy link
Contributor Author

n-l-i commented Apr 29, 2025

Of course @jgadsden! So when I was reading the current wording, "Only send non-temporary passwords over an encrypted connection or as encrypted data", I was initially thinking "huh? why should only non-temporary passwords be sent encrypted? what is wrong with sending temporary passwords encrypted?". But they don't mean that only non-temporary passwords should be sent encrypted, but rather that non-temporary passwords should only ever be sent encrypted and never in plaintext. The sentence can be read both ways, however, and both readings are equally grammatically correct (afaik). The change in wording in this PR is my attempt at removing the ambiguity with minimal changes to the original entry.

Copy link
Contributor

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @n-l-i , and I wil go ahead and merge
It is unusual for a pull-request to be a single word change :)

@jgadsden jgadsden merged commit ea81c31 into OWASP:main Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants