Sidebar migration to chakra ui #1113

Dishant1804 · 2025-03-15T14:05:55Z

Resolves #700

Sidebar migrated to ChakraUI and it is now more clean and readable
Fixed the responsive behaviour of home page

Before

2025-03-15.19-16-59.mp4

After

2025-03-15.19-17-42.mp4

coderabbitai · 2025-03-15T14:06:02Z

Summary by CodeRabbit

New Features
- Mobile menu now uses a modern modal interface for a smoother and more intuitive navigation experience on mobile devices.
Style
- Updated home page layouts improve responsiveness with enhanced text wrapping and clear element alignment across various screen sizes.

Walkthrough

This pull request refactors the mobile menu functionality in the Header component by replacing a custom outside click handler with Chakra UI’s Drawer and Portal components. The implementation now uses the onInteractOutside prop to manage menu closure. Additionally, the Home page has been updated to improve responsiveness by adjusting text wrapping and flex layouts for various screen sizes, along with minor structural refinements.

Changes

File(s)	Change Summary
frontend/.../Header.tsx	Refactored mobile menu: replaced custom click outside handling with Chakra UI’s Drawer (and Portal) using `onInteractOutside`; removed previous `handleOutsideClick` function and related event listener.
frontend/.../Home.tsx	Modified typography and layout: updated `<h3>` classes for text wrapping; altered flex container layouts from `flex-wrap` to `flex-col` on small screens and `flex-row` on larger screens; encapsulated post author names in a `<div>`.
frontend/.../e2e/pages/Contribute.spec.ts	Updated dialog interaction test: simplified button retrieval and visibility checks for dialog content and links to improve clarity and reduce reliance on specific locators.

Possibly related PRs

migrate: footer component to chakra-ui #1018: The changes in the main PR for the Header.tsx file, which involve refactoring to use Chakra UI components, are related to the changes in the retrieved PR for the Footer.tsx file, as both involve migrating components to utilize Chakra UI for improved styling and structure.

Suggested labels

frontend-tests

Suggested reviewers

kasya
arkid15r

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50819f1 and ce87e6e.

📒 Files selected for processing (1)

frontend/__tests__/e2e/pages/Contribute.spec.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: CodeQL (python)
GitHub Check: CodeQL (javascript-typescript)
GitHub Check: Run frontend unit tests
GitHub Check: Run frontend e2e tests
GitHub Check: Run backend tests

🔇 Additional comments (4)

frontend/__tests__/e2e/pages/Contribute.spec.ts (4)

44-44: Improved element selection for better test reliability.

The changes here improve the test by:

Correctly removing the unnecessary await since getByRole() returns a Locator, not a Promise

Adding .first() to specifically target the first matching button, making the test more robust if multiple "Read More" buttons exist

46-47: Better dialog handling approach.

Storing the dialog element in a variable and then checking its visibility is a good practice for:

Better code organization

Reusability throughout the test

Clearer intent of what's being tested

49-52: Improved text verification within dialog context.

Scoping the text verification to within the dialog context using dialog.getByText() instead of page-level verification makes the test more precise and less susceptible to false positives if similar text appears elsewhere on the page.

53-53: Better link verification scoping.

Checking for the "View Issue" link within the dialog context rather than globally on the page ensures you're verifying the correct element, making the test more accurate and reliable.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Dishant1804 · 2025-03-15T14:13:16Z

The test which is failing is not even related to the issue and i haven't even touched the contribute page 🤷‍♂️
how come it is failing here🤔

Dishant1804 · 2025-03-15T15:18:08Z

The test which is failing is not even related to the issue and i haven't even touched the contribute page 🤷‍♂️ how come it is failing here🤔

I have fixed the test, there was no requirement of the dynamic id as it can vary, also all the expected things are now rendered correctly, thus passing the tests and giving us expected outcome :)

arkid15r

LGTM

sonarqubecloud · 2025-03-15T16:28:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* navbar improvements * fixed contibute e2e test * checks and lint --------- Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

navbar improvements

50819f1

Dishant1804 requested review from arkid15r and kasya as code owners March 15, 2025 14:05

github-actions bot added the frontend label Mar 15, 2025

Dishant1804 added 2 commits March 15, 2025 20:37

fixed contibute e2e test

2bf3437

checks and lint

ce87e6e

github-actions bot added the frontend-tests label Mar 15, 2025

Merge branch 'main' into header_chakraui

457e9bf

Dishant1804 changed the title ~~Header migration to chakra ui~~ Sidebar migration to chakra ui Mar 15, 2025

Merge branch 'main' into header_chakraui

6e2b4ea

arkid15r enabled auto-merge March 15, 2025 16:28

arkid15r approved these changes Mar 15, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Mar 15, 2025

Merged via the queue into OWASP:main with commit b90b337 Mar 15, 2025
18 checks passed

This was referenced Mar 16, 2025

Truncated text component #1117

Merged

Fixed issue: 1082 Fixing the top contributors card to make it similar to rest #1129

Closed

This was referenced Mar 27, 2025

Issue resoved: 1182: cleared getTestId #1185

Merged

Implement Dynamic Labels & Repository Languages in the Contribute Page #1126

Closed

Enhancing sub links dropdown for header #1218

Merged

shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025

Sidebar migration to chakra ui (OWASP#1113)

9ee2298

* navbar improvements * fixed contibute e2e test * checks and lint --------- Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>

coderabbitai bot mentioned this pull request Jul 27, 2025

Header Component #1881

Merged

This was referenced Aug 29, 2025

Upgrade TailwindCSS to v.4.1.12 #2153

Merged

fix: footer sticks to bottom and remove duplicate nav #2160

Closed

fix(ui): improve mobile navigation menu in Header.tsx #2217

Merged

coderabbitai bot mentioned this pull request Sep 6, 2025

Move Sign In to mobile side nav; hide in header on small screens #2227

Closed

coderabbitai bot mentioned this pull request Sep 8, 2025

Move Sign in button from Header to Side nav when on small devices. #2231

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sidebar migration to chakra ui #1113

Sidebar migration to chakra ui #1113

Uh oh!

Dishant1804 commented Mar 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 15, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Dishant1804 commented Mar 15, 2025

Uh oh!

Dishant1804 commented Mar 15, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

sonarqubecloud bot commented Mar 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Sidebar migration to chakra ui #1113

Sidebar migration to chakra ui #1113

Uh oh!

Conversation

Dishant1804 commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

coderabbitai bot commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Dishant1804 commented Mar 15, 2025

Uh oh!

Dishant1804 commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 15, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dishant1804 commented Mar 15, 2025 •

edited

Loading

coderabbitai bot commented Mar 15, 2025 •

edited

Loading

Dishant1804 commented Mar 15, 2025 •

edited

Loading