Skip to content

Conversation

@swastika1011
Copy link
Contributor

Resolves #919
Add the PR description here:

  • Fixed responsiveness issues on the contribute page.
  • Ensured consistent dimensions across different screen sizes.

WhatsApp Image 2025-03-17 at 21 23 45_95f3e7a6
WhatsApp Image 2025-03-17 at 21 08 09_a60d3507

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2025

Summary by CodeRabbit

  • Chores
    • Revised internal configuration to better manage project files.
  • Style
    • Refined the card display layout and spacing for improved responsiveness and alignment.

Walkthrough

This pull request introduces two main changes. The first change adds a new entry, tash list, to the .gitignore file to prevent matching files or directories from being tracked by Git. The second change modifies the styling of the primary <div> element in the Card component by adjusting class attributes—specifically altering the maximum width and adding padding and centering classes—to better control its layout and responsiveness.

Changes

File(s) Change Summary
.gitignore Added new ignore pattern tash list
frontend/.../Card.tsx Modified main <div> class list: replaced max-w-full with max-w-[95%] and added px-4 and mx-auto to adjust layout and responsiveness

Assessment against linked issues

Objective Addressed Explanation
Fix container layout for mobile responsiveness (#919)

Suggested reviewers

  • kasya
  • arkid15r

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c20a83 and 5341e27.

📒 Files selected for processing (2)
  • .gitignore (1 hunks)
  • frontend/src/components/Card.tsx (1 hunks)
🔇 Additional comments (2)
.gitignore (1)

38-38: Verify the intended entry: Is "tash list" a typo?

The added gitignore entry "tash list" appears unusual, as it contains a space and doesn't match common file patterns. It might be a typo for "trash list" or possibly intended for a specific project file.

Please confirm if this is the correct entry or if it should be modified to a more standard format (typically without spaces) or corrected if it's a typo.

frontend/src/components/Card.tsx (1)

46-46: Layout improvements for better responsiveness

The changes to the Card component's main container improve responsiveness by:

  1. Setting maximum width to 95% instead of full width
  2. Adding horizontal padding with px-4
  3. Centering the card with mx-auto

These changes will help maintain consistent dimensions and ensure proper display across different screen sizes, which aligns well with the PR objective to fix the contribute page responsiveness.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkid15r arkid15r enabled auto-merge March 17, 2025 20:27
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@arkid15r arkid15r added this pull request to the merge queue Mar 17, 2025
Merged via the queue into OWASP:main with commit 36137b3 Mar 17, 2025
15 of 16 checks passed
@swastika1011
Copy link
Contributor Author

@arkid15r I just noticed that the issue still persists on the live website, even though it works fine in my local environment. I found the probable cause (padding-right is set to 39px on the live site). I'm still checking why it's different from my local setup, but I'll make the necessary changes and update you soon.

@rishyym0927
Copy link
Contributor

@arkid15r I just noticed that the issue still persists on the live website, even though it works fine in my local environment. I found the probable cause (padding-right is set to 39px on the live site). I'm still checking why it's different from my local setup, but I'll make the necessary changes and update you soon.

Hey @swastika1011 The reason why you can't see changes in the deployed websites because your code is not deployed instantly, it is released in every 2-3 days. Don't worry about it your changes will reflect soon

shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
* Fixed responsive issue in contribute page

* Applied code quality fixes

* Update code

---------

Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribute element container exceeds screen width on mobile

3 participants