-
-
Notifications
You must be signed in to change notification settings - Fork 274
configure lighthouse for local development/testing #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arkid15r
merged 13 commits into
OWASP:main
from
rudransh-shrivastava:feature/ci-lighthouse-local
Aug 26, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a936333
configure lighthouse-ci to run locally
rudransh-shrivastava 508b0cd
use environment variables instead of flags, upload to artifacts
rudransh-shrivastava 9bd7d77
test CI
rudransh-shrivastava 7537508
add spelling, fix artifact dir, include hidden files
rudransh-shrivastava f747ec0
Remove artifact upload
rudransh-shrivastava 140280b
Update code
rudransh-shrivastava 4c54029
add config for multiple routes/urls
rudransh-shrivastava c7a2825
test CI
rudransh-shrivastava 05bb9ef
Update code
rudransh-shrivastava 253447a
Update code
rudransh-shrivastava d7c80dc
Merge branch 'main' into feature/ci-lighthouse-local
rudransh-shrivastava c391377
Merge branch 'main' into pr/rudransh-shrivastava/2122-1
arkid15r f8b360f
Update code
arkid15r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,6 +71,7 @@ jumpstart | |
| kasya | ||
| lhci | ||
| libexpat | ||
| lighthouseci | ||
| linkify | ||
| lte | ||
| lxml | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| const LHCI_BASE_URL = process.env.LHCI_BASE_URL || 'http://localhost:3000' | ||
| const LHCI_CHROME_FLAGS = | ||
| process.env.LHCI_CHROME_FLAGS || '--disable-dev-shm-usage --headless --no-sandbox' | ||
|
|
||
| const URL_PATHS = [ | ||
| '/', | ||
| '/about', | ||
| '/chapters', | ||
| '/contribute', | ||
| '/members', | ||
| '/organizations', | ||
| '/projects', | ||
| '/snapshots', | ||
| ] | ||
|
|
||
| module.exports = { | ||
| ci: { | ||
| assert: { | ||
| assertions: { | ||
| 'categories:accessibility': ['warn', { minScore: 0.9 }], | ||
| 'categories:best-practices': ['warn', { minScore: 0.9 }], | ||
| 'categories:performance': ['warn', { minScore: 0.9 }], | ||
| 'categories:seo': ['warn', { minScore: 0.9 }], | ||
| }, | ||
| }, | ||
| collect: { | ||
| numberOfRuns: 1, | ||
| settings: { | ||
| chromeFlags: LHCI_CHROME_FLAGS, | ||
| }, | ||
| url: URL_PATHS.map((url_path) => `${LHCI_BASE_URL}${url_path}`), | ||
| }, | ||
| upload: { | ||
| target: 'temporary-public-storage', | ||
| }, | ||
| }, | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between those 2 targets? Do we need the desktop preset for local running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, lighthouse opens all pages as a mobile device, this is if we want to test the desktop version
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not required, testing as a mobile device is enough but I think accessibility and some UI may differ for both devices, it's a good to have