-
-
Notifications
You must be signed in to change notification settings - Fork 321
Added missing type="button" to multiple components #2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR adds explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The linked issue must be assigned to the PR author. |
|
|
The linked issue must be assigned to the PR author. |



🛠 Summary
This pull request adds the missing type="button" attributes to several button elements across the project.
This prevents unintended form submissions (since buttons inside forms default to type="submit") and ensures consistent, predictable behavior.
Resolves #2656
🔧 Proposed Changes
Updated components to explicitly set type="button" where necessary:
frontend/src/components/ModuleList.tsx
frontend/src/components/ProgramActions.tsx
frontend/src/components/RecentIssues.tsx
frontend/src/components/RecentPullRequests.tsx
frontend/src/components/Release.tsx
frontend/src/components/RepositoryCard.tsx
frontend/src/components/ScrollToTop.tsx
📋 Checklist
I’ve read and followed the contributing guidelines
.
I’ve run make check-test locally; all checks and tests passed