Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - userId variable isnt set when viewing the memos page #89

Merged
merged 3 commits into from
Mar 7, 2017
Merged

Fix - userId variable isnt set when viewing the memos page #89

merged 3 commits into from
Mar 7, 2017

Conversation

lirantal
Copy link
Collaborator

Fixes #88

@lirantal
Copy link
Collaborator Author

@binarymist @ckarande I can't assign any of you as reviewers, would be nice in the future.

@ckarande
Copy link
Member

@lirantal The changes look good and fixes the issue. Do you mind running grunt precommit and take care of any linting rules before I merge this PR. Thanks

@lirantal
Copy link
Collaborator Author

lirantal commented Mar 6, 2017

Sure @ckarande, I commited a fix with all out-standing jsbeautify items resulted from grunt precommit with the exception of small long lines linting on test/security/profile-test.js which I didn't touch and I'll skip for now.

@ckarande
Copy link
Member

ckarande commented Mar 7, 2017

@lirantal This is great! Thanks

@ckarande ckarande merged commit dcb7c73 into OWASP:master Mar 7, 2017
@lirantal
Copy link
Collaborator Author

lirantal commented Mar 7, 2017

My pleasure, thanks for keeping up with this great project.

@snyk-bot snyk-bot mentioned this pull request Mar 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lirantal @ckarande