Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Timezone, Logs volume, and letsencrypt #707

Closed
rudosch opened this issue Oct 22, 2022 · 5 comments
Closed

[Enhancement] Timezone, Logs volume, and letsencrypt #707

rudosch opened this issue Oct 22, 2022 · 5 comments
Assignees

Comments

@rudosch
Copy link
Contributor

rudosch commented Oct 22, 2022

Some enhancement suggestions, either to be implemented or added to documentation (e.g. on docker environment setup page and/or wiki):

  • Timezone : add e.g. CATALINA_OPTS="-Duser.timezone=Europe/Zurich" to the .env file to assure correct timezone
  • Logs : configure additional docker volume securityshepherd_logs in docker-compose.yml file to have persistent logs across tomcat builds
  • letsencrypt : document how to adapt Dockerfile and serverxml.patch to use letsencrypt certificates (add to wiki ?). I can provide example files.

All these suggestions have been successfully tested using dev branch.

Side note : just removing tomcat container isn't sufficient if tweaking tomcat configuration, docker conf volume has to be removed before re-build, too. Maybe this note should be added to the docker environment setup page.

I apologize for the wrong issue label!

@rudosch rudosch added the Bug label Oct 22, 2022
@ismisepaul
Copy link
Member

Thanks @rudosch would you be able to provide examples for letsencrypt?

Also could you create a pull request based on your 3 points?

@rudosch
Copy link
Contributor Author

rudosch commented Oct 25, 2022

I will do a pull request for timezone and logs, these are simple line additions.

But for letsencrypt I think it would be better to document the needed steps in the wiki and not directly integrate those modifications in the dev (or main) branch. Otherwise, a compromise could be to add Dockerfile-letsencrypt and serverxml-letsencrypt.patch to the dev branch.

To use a letsencrypt certificate the following steps are needed:

What do you think?

@ismisepaul
Copy link
Member

Thanks @rudosch this is awesome!

I've gone with your first suggestion and added it to the wiki https://github.com/OWASP/SecurityShepherd/wiki/How-to-Utilise-Let's-Encrypt-with-Docker

I've also located it under Customizing

If you could take a look, if you're happy you can go ahead with closing this issue. If there's adjustments I can go ahead and do that with you feedback. I've also reviewed and approved your PR you just need to hit the button to merge.

@rudosch
Copy link
Contributor Author

rudosch commented Nov 3, 2022

The solution of listing the procedure in the "Customizing" section seems perfect to me. Thus I will close this issue.
But I don't think I have permission to trigger the merge ...

@rudosch rudosch closed this as completed Nov 3, 2022
@ismisepaul
Copy link
Member

Thanks for the contribution @rudosch I've merged in #dev707 just there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants