-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Timezone, Logs volume, and letsencrypt #707
Comments
Thanks @rudosch would you be able to provide examples for letsencrypt? Also could you create a pull request based on your 3 points? |
I will do a pull request for timezone and logs, these are simple line additions. But for letsencrypt I think it would be better to document the needed steps in the wiki and not directly integrate those modifications in the To use a letsencrypt certificate the following steps are needed:
What do you think? |
Thanks @rudosch this is awesome! I've gone with your first suggestion and added it to the wiki https://github.com/OWASP/SecurityShepherd/wiki/How-to-Utilise-Let's-Encrypt-with-Docker I've also located it under Customizing If you could take a look, if you're happy you can go ahead with closing this issue. If there's adjustments I can go ahead and do that with you feedback. I've also reviewed and approved your PR you just need to hit the button to merge. |
The solution of listing the procedure in the "Customizing" section seems perfect to me. Thus I will close this issue. |
Thanks for the contribution @rudosch I've merged in #dev707 just there 👍 |
Some enhancement suggestions, either to be implemented or added to documentation (e.g. on docker environment setup page and/or wiki):
CATALINA_OPTS="-Duser.timezone=Europe/Zurich"
to the.env
file to assure correct timezonesecurityshepherd_logs
indocker-compose.yml
file to have persistent logs across tomcat buildsDockerfile
andserverxml.patch
to use letsencrypt certificates (add to wiki ?). I can provide example files.All these suggestions have been successfully tested using
dev
branch.Side note : just removing tomcat container isn't sufficient if tweaking tomcat configuration, docker
conf
volume has to be removed before re-build, too. Maybe this note should be added to the docker environment setup page.I apologize for the wrong issue label!
The text was updated successfully, but these errors were encountered: