-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mlc_config.json #1958
Update mlc_config.json #1958
Conversation
any ideas on what to do with the 403s @anantshri? |
@cpholguera my suggestion would be to keep adding domains in the ignore pattern for now. till the list is now growing above 100 entries. If it does that cross it then we think of something else. a possible logic could be look for 403 with cloudflare in text then its okey if not then raise a flag. |
ok. Thanks for the feedback @anantshri . But we really need to come up with a solution for this. It's very disturbing for contributors and for us always having to explain that it's ok that this check fails. I'll enable the option to only check changed files for PRs. This should improve the experience, if someone's introducing a new dead link it will be reported. If it's not dead, the contributors have to add the exceptions themselves to this list. This will be of course documented. For now I'll add these to the list: https://www.verticalstructure.com |
Just a note tcort/markdown-link-check#109 is the issue in markdown-link-check which should sort this out eventually. |
Great, thanks for checking that @anantshri, very helpful! |
Thank you for the workaround @cpholguera and @anantshri! |
allow only code 200 for alive