Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mlc_config.json #1958

Merged
merged 9 commits into from
Nov 2, 2021
Merged

Update mlc_config.json #1958

merged 9 commits into from
Nov 2, 2021

Conversation

cpholguera
Copy link
Collaborator

allow only code 200 for alive

@cpholguera
Copy link
Collaborator Author

any ideas on what to do with the 403s @anantshri?

@anantshri
Copy link
Collaborator

@cpholguera my suggestion would be to keep adding domains in the ignore pattern for now. till the list is now growing above 100 entries.

If it does that cross it then we think of something else. a possible logic could be look for 403 with cloudflare in text then its okey if not then raise a flag.

@cpholguera
Copy link
Collaborator Author

ok. Thanks for the feedback @anantshri . But we really need to come up with a solution for this. It's very disturbing for contributors and for us always having to explain that it's ok that this check fails.

I'll enable the option to only check changed files for PRs. This should improve the experience, if someone's introducing a new dead link it will be reported. If it's not dead, the contributors have to add the exceptions themselves to this list. This will be of course documented.

For now I'll add these to the list:

https://www.verticalstructure.com
https://support.virustotal.com/hc/en-us/articles/115002146549-Mobile-Apps

@anantshri
Copy link
Collaborator

Just a note tcort/markdown-link-check#109 is the issue in markdown-link-check which should sort this out eventually.

@cpholguera
Copy link
Collaborator Author

Great, thanks for checking that @anantshri, very helpful!

@sushi2k
Copy link
Collaborator

sushi2k commented Nov 2, 2021

Thank you for the workaround @cpholguera and @anantshri!

@sushi2k sushi2k merged commit c054b4a into master Nov 2, 2021
@cpholguera cpholguera deleted the cpholguera-patch-4 branch November 20, 2021 10:04
@cpholguera cpholguera added the org label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants