Increase Checklist Test Coverage Including Tests from the 0x04* Chapters #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpholguera
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
@fujiokayu this is excellent. Your enhancement works perfectly and increases the coverage by +29 test cases! Thank you so much for taking the time to analyze the script and enhance it.
cpholguera
changed the title
|
Thanks @cpholguera for checking the generated files. Now I understand a bit more about these scripts. |
|
@fujiokayu thank you very much for the offer. We'll need help soon with both scripting as restructuring the MASVS and MSTG. We'd love to have you as part of our active team. Let's get in touch on Slack. |
|
@cpholguera Ok, I'm already on OWASP Slack, so please feel free to send me a mention to "Yu Fujioka" anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the PR as discussed in #2082.
However, this is a mitigation measure specific to requirements with common test cases (e.g., V4 and V5).
It does not fulfill the requirements associated with V1 or those requiring multiple test cases.
The test case coverage in the new version of the checklist increases in +29 tests:
This PR closes #2084.