Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static analysis details for Android keyboard cache #2254

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Add static analysis details for Android keyboard cache #2254

merged 4 commits into from
Oct 3, 2022

Conversation

DIvanov503
Copy link
Contributor

@DIvanov503 DIvanov503 commented Sep 21, 2022 •
edited
Loading

  • Recommend more input types disabling keyboard cache
  • Add a check for SDK version
  • Add a check for programmatic input type overwriting

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

@DIvanov503
Add static analysis details for Android keyboard cache
2ec50ec 
- Recommend more input types disabling keyboard cache
- Add a check for SDK version
- Add a check for programmatic input type overwriting
@cpholguera
Copy link
Collaborator

Thank you for the addition @DIvanov503, we'll take a look very soon.

cpholguera
cpholguera requested changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DIvanov503, this is great! I've included another constant, made a table for the data and moved the "check the code" paragraph up so that it is closer to the table. If you agree just click on "Commit suggestion". If you have other suggestions or comments just let me know. Thank you!

Document/0x05d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
Document/0x05d-Testing-Data-Storage.md Outdated Show resolved Hide resolved
DIvanov503 and others added 2 commits October 3, 2022 17:13
@DIvanov503 @cpholguera
Update Document/0x05d-Testing-Data-Storage.md
e8dab70 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@DIvanov503 @cpholguera
Update Document/0x05d-Testing-Data-Storage.md
c8b72f3 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@DIvanov503
Copy link
Contributor Author

Thank you for nice edits @cpholguera!

cpholguera
cpholguera approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks s lot for the additions @DIvanov503, we're ready to go 🚀

@cpholguera cpholguera merged commit 267a0ee into OWASP:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
Android MASVS-STORAGE tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DIvanov503 @cpholguera