Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proofreading fixes part 1 0x05b #2293

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Proofreading fixes part 1 0x05b #2293

merged 3 commits into from
Oct 24, 2022

Conversation

Laancelot
Copy link
Contributor

part 1... mainly links

the links that I removed were broken

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

cpholguera
cpholguera requested changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laancelot, please take a look at the suggestions.

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Laancelot and others added 2 commits October 24, 2022 11:00
@Laancelot @cpholguera
Applying suggested changes
0ef2111 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@Laancelot @cpholguera
Applying suggested changes
1d5fe99 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
cpholguera
cpholguera approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laancelot!

@cpholguera cpholguera merged commit eb9a70c into OWASP:master Oct 24, 2022
@cpholguera cpholguera changed the title Proofreading fixes 0x05b-Basic-Security_Testing.md Proofreading fixes part 1 0x05b May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
Android fundamentals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laancelot @cpholguera