Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading fixes part 2 0x05b #2297

Merged
merged 9 commits into from
Oct 27, 2022
Merged

Proofreading fixes part 2 0x05b #2297

merged 9 commits into from
Oct 27, 2022

Conversation

Laancelot
Copy link
Contributor

Links, typos

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

Copy link

@Faby666 Faby666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Laancelot, thanks for adding missing links.

I got just one comment to that.

Instead of:

 "[Recommended Tools - Objection](https://github.com/OWASP/owasp-mastg/blob/master/Document/0x08a-Testing-Tools.md#objection "Testing Tools - Objection")"

It should be:

 "[Recommended Tools - Objection](0x08a-Testing-Tools.md#objection "Testing Tools - Objection")"

Could you please correct them? Thank you very much!

@Laancelot
Copy link
Contributor Author

done @cpholguera

@cpholguera
Copy link
Collaborator

I'm sorry @Laancelot but the GitHub rendering for the markdown block above was broken and it was showing a link instead of a block of code. Please take another look because the links are different. Thank you very much again!

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending the right links as suggestions, thanks @Laancelot!

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
Laancelot and others added 3 commits October 27, 2022 10:05
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laancelot!

Document/0x05b-Basic-Security_Testing.md Outdated Show resolved Hide resolved
@cpholguera cpholguera merged commit 6972cc6 into OWASP:master Oct 27, 2022
@cpholguera cpholguera changed the title Proofreading fixes part 2 - Android basic security testing Proofreading fixes part 2 0x05b May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants