Add enum for DatastoreType used in Datastore objects, removed isSQL, … #179
Conversation
…updated sample tm, and updated existing tests
|
Let me know if anyone has thoughts on values for DatastoreType enum. |
| @@ -214,7 +216,7 @@ def test_defaults(self): | |||
| {"target": func, "condition": "not any(target.inputs)"}, | |||
| { | |||
| "target": server, | |||
| "condition": "any(f.sink.oneOf(Datastore) and f.sink.isSQL " | |||
| "condition": "any(f.sink.oneOf(Datastore) and f.sink.type == DatastoreType.SQL " | |||
There was a problem hiding this comment.
What if we'd use subclasses instead of a dedicated attribute? It looks weird to do two different kind of type assertion here, oneOf() and type == Enum, instead we could stick to only oneOf(). It also makes it easier to extend pytm by defining subclasses, as adding values to an existing Enum would require monkey-patching.
There was a problem hiding this comment.
Unless we think there would be specific annotations for the subclasses I'd rather leave them as Datastore with annotations for what it is .. but I guess I could subclass DatastoreType then you could oneOf the type and accomplish the same thing.
|
I realized the readme and docs have to get updated as well. I haven't looked into how the doc html is generated yet but will before merge. |
Just run |
…updated sample tm, and updated existing tests