Added prerequisites and likelihood to Threat
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In threats.json the two properties ("prerequisites", "Likelihood Of Attack") are defined, but are not used in the
rest of pytm.
This commit adds the two properties to the Threat class, so they can be
used by other parts of pytm.
For me this was relevant, since I started to experiment with a different
format for threats mentioned in OWASP#237 .
And after exporting threat.json to a markdown format and back into
threat.json these two fields where missing.
izar
approved these changes
Apr 12, 2024
|
thanks! |
|
One question do you want to use the values somewhere? They could be used in the findings, but I still wonder why they where not in the Threat class and if there was a reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In threats.json the two properties ("prerequisites", "Likelihood Of Attack") are defined, but are not used in the rest of pytm.
This commit adds the two properties to the Threat class, so they can be used by other parts of pytm.
For me this was relevant, since I started to experiment with a different format for threats mentioned in #237 .
And after exporting threat.json to a markdown format and back into threat.json these two fields where missing.